search

D3DEnergetic / FIDASIM

A Neutral Beam and Fast-ion Diagnostic Modeling Suite
http://d3denergetic.github.io/FIDASIM/
Other
29 stars 19 forks source link

Whjh/prefida vmec #281

Closed hayashiw closed 1 month ago

hayashiw commented 3 months ago

Added VMEC .wout file io for text and NETCDF files. Added utils to convert to FIDASIM fields and igrid objects. Validated against LHD case (GNET-FIDASIM) using VMEC version 6.90.

VMEC_to_GNETFIDASIM_comparison

Important

  1. Compatibility with other versions and with NETCDF files still needs to be validated.
  2. COCOS numbers should be considered when using the utils/Brzp_transform function.
    • It might help to have a lookup table in the documentation for COCOS numbers for various devices. From what I gather, LHD uses COCOS 8
lstagner commented 3 months ago

We cant really have a cocos lookup per device as it is code dependent. Ideally each code always outputs the same cocos or at the very least it states it in the output file.

hayashiw commented 3 months ago

Closing this pull request because only python functionality is implemented. Will reopen when IDL functionality is implemented.

lstagner commented 3 months ago

Personally I don't think we need to have IDL anymore but I'm guessing Bill and a few others would like it.

hayashiw commented 3 months ago

@lstagner do you want to merge it as is with only the python version and leave the IDL for later if it's requested?

lstagner commented 3 months ago

I believe so yes. IDL usage has fallen pretty low and I don't see many people complaining that we don't have IDL support for VMEC. We shouldn't bother unless people complain (or if Bill wants it).

lstagner commented 1 month ago

Going to merge this later today if there isnt anything else.