D3_BUILDID doesn't build with recent compiler - Githubissues

D3Engineering / d3-jetson-bsp

Board support package for Nvidia Jetson products.

14 stars 12 forks source link

D3_BUILDID doesn't build with recent compiler #11

Open RomainNaour opened 3 years ago

RomainNaour commented 3 years ago

Hello,

D3_JETSON_BSP_BUILDID is set by using uuidgen and it's used in build-id.c to check if the kernel and devicetree have the same build_id.

$ uuidgen -r f2319915-fbb7-4c98-ae41-67292acdd866

https://github.com/D3Engineering/d3-jetson-bsp/blob/d3/3.0.1/kernel/d3/drivers/d3/build-id/build-id.c#L25

But there is a problem with the format used by MODULE_VERSION() macro:

The may contain only alphanumerics and the character '.' https://github.com/D3Engineering/nvidia-kernel-kernel-4.9/blob/d3/3.0.1/include/linux/module.h#L226

This break the build with gcc 8.

Best regards, Romain

cxw42 commented 3 years ago

Does it actually prevent compilation, or does it just not match the standard described in the comments? If it actually breaks the build, please post the error log. The version member in module.h is just a const char * (here).

I am currently using aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) 7.5.0.