D4-project / IPASN-History

IP ASN History to find ASN announcing an IP and the closest prefix announcing it at a specific date
https://www.d4-project.org/open%20source/asn/history/2019/01/09/IP-ASN-History.html
GNU Affero General Public License v3.0
91 stars 12 forks source link

fix: Added exception handling when specify a key that does not exist in `SISMEMBER` #29

Closed fukusuket closed 1 year ago

fukusuket commented 1 year ago

I tried to fix #28 :)

What Changed

Evidence

Environment

Same as #28 reproduction environment

After this fix, I confirmed that ASN data can be added to kvrocks as follows.

2023-08-10 01:52:20,247 RipeDownloader INFO:Unreachable: http://data.ris.ripe.net/rrc00/2023.08/bview.20230810.0000.gz
2023-08-10 01:52:20,249 RipeDownloader INFO:Launching RipeDownloader
2023-08-10 01:52:20,250 RipeDownloader INFO:New file to download: rrc00/2023.08/bview.20230810.0000.gz
2023-08-10 01:52:21,102 CaidaDownloader INFO:Launching CaidaDownloader
2023-08-10 01:52:21,549 RipeDownloader INFO:Unreachable: http://data.ris.ripe.net/rrc00/2023.08/bview.20230810.0000.gz
2023-08-10 01:52:24,518 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v6/2023/08/routeviews-rv6-20230807-1000.pfx2as.gz
2023-08-10 01:52:30,057 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v6/2023/08/routeviews-rv6-20230806-1400.pfx2as.gz
2023-08-10 01:52:35,568 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v6/2023/08/routeviews-rv6-20230805-1200.pfx2as.gz
2023-08-10 01:52:41,109 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v6/2023/08/routeviews-rv6-20230804-1200.pfx2as.gz
2023-08-10 01:52:46,739 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v6/2023/08/routeviews-rv6-20230803-1200.pfx2as.gz
2023-08-10 01:52:52,608 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v6/2023/08/routeviews-rv6-20230802-1800.pfx2as.gz
2023-08-10 01:52:58,194 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v6/2023/08/routeviews-rv6-20230801-1400.pfx2as.gz
2023-08-10 01:53:03,891 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v6/2023/07/routeviews-rv6-20230731-1200.pfx2as.gz
2023-08-10 01:53:09,645 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v4/2023/08/routeviews-rv2-20230808-1200.pfx2as.gz
2023-08-10 01:53:25,972 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v4/2023/08/routeviews-rv2-20230807-1200.pfx2as.gz
2023-08-10 01:53:41,997 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v4/2023/08/routeviews-rv2-20230806-1200.pfx2as.gz
2023-08-10 01:53:58,768 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v4/2023/08/routeviews-rv2-20230805-2200.pfx2as.gz
2023-08-10 01:54:15,259 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v4/2023/08/routeviews-rv2-20230804-1400.pfx2as.gz
2023-08-10 01:54:32,416 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v4/2023/08/routeviews-rv2-20230803-1800.pfx2as.gz
2023-08-10 01:54:48,342 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v4/2023/08/routeviews-rv2-20230802-1200.pfx2as.gz
2023-08-10 01:55:05,402 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v4/2023/08/routeviews-rv2-20230801-1000.pfx2as.gz
2023-08-10 01:55:22,037 CaidaLoader INFO:Loading /home/fukusuke/IPASN-History/rawdata/caida/v4/2023/07/routeviews-rv2-20230731-1200.pfx2as.gz

I was able to run the API as follows.

$ curl http://127.0.0.1:5176/ip?ip=8.8.8.8
{"meta": {"ip": "8.8.8.8"}, "response": {"2023-08-08T12:00:00": {"asn": "15169", "prefix": "8.8.8.0/24", "source": "caida"}}}

I was able to run it from the GUI as follows.

スクリーンショット 2023-08-10 2 07 33

I would appreciate it if you could review. Regards,

adulau commented 1 year ago

Nice catch! Thank you!