search

D4koon / WhatsappTray

Minimize Whatsapp Desktop-Client to Tray
GNU General Public License v3.0
388 stars 31 forks source link

New message detection has false postives. #35

Closed D4koon closed 2 years ago

D4koon commented 5 years ago

It is not 100% correct. Im not sure if it is possible to differentiated between messages and whatever causes the false postives with the current method of detection.

nickluijtgaarden commented 5 years ago

I also noticed some false positives when I quickly tested the new version last night.

arrmo commented 5 years ago

Yes, just this morning I saw the icon number "climb" ... to 1, then 2 - but no messages arrived. Is it perhaps WhatsApp just refreshing the icon in some way, and this is being counted?

Would any logs help?

Thanks!

arrmo commented 5 years ago

BTW, just a thought (and feel free to disagree!), but ... it seems like the code is just incrementing when it detects a new message, and clears when WhatsApp is opened - do I have that right? If that's the case, why worry about trying to count (as it can easily get out of sync), rather just change it icon color (same logic).

Of course, this all does depend on getting to the bottom of the false positives ... :-). Trying to find the recipe there, no luck yet.

D4koon commented 5 years ago

TW, just a thought (and feel free to disagree!), but ... it seems like the code is just incrementing when it detects a new message, and clears when WhatsApp is opened - do I have that right? Yes you are right.

why worry about trying to count (as it can easily get out of sync), rather just change it icon color (same logic). Thanks for your suggestion. If it would hide all cases of false postive i would agree that it would be the way to go. But if there is no real message and then a false detection happens it would still be wrong. So it just a little bit better, which is not enough reason for me to change it.

arrmo commented 5 years ago

Absolutely agreed - no issues here at all. As you say, first step is to solve the false detection. Yell if any logs (or something else) would help.

Thanks!

kosmic0 commented 5 years ago

TW, just a thought (and feel free to disagree!), but ... it seems like the code is just incrementing when it detects a new message, and clears when WhatsApp is opened - do I have that right? Yes you are right.

why worry about trying to count (as it can easily get out of sync), rather just change it icon color (same logic). Thanks for your suggestion. If it would hide all cases of false postive i would agree that it would be the way to go. But if there is no real message and then a false detection happens it would still be wrong. So it just a little bit better, which is not enough reason for me to change it.

suggestion that when new message arrive the icon just blinks no message count needed

arrmo commented 5 years ago

I think the key first step is understand the false positives. Then the indication mechanism can be whatever (@D4koon) decides - IMHO that's his call.

Thanks!

steffmartin commented 5 years ago

Seems like the code is counting messages from muted conversations too

wimg commented 5 years ago

I noticed I often have a "1" but in fact no messages are unread.

Novack commented 5 years ago

Yes is happening constantly for me too, not yet grasped where is coming from.

wimg commented 5 years ago

Looks like it's escalating. Maybe something has changed in the way WhatsApp works, but I'm now getting a false positive every 10-15 minutes, so my counter keeps going up, even when I'm not receiving messages.

StragaSevera commented 5 years ago

I have the same problem. When I minimize to tray, I will get a false positive in 5-10 minutes, and then often second and third. I have no muted conversations, nothing. Please, help!

Novack commented 5 years ago

I suspect this is related to the whatsapp Stories.

eraser-head commented 5 years ago

I suspect this is related to the whatsapp Stories.

Yes and not, when I change my inet status through VPN, show me a show a new notification to.

arrmo commented 4 years ago

Just a thought, but - would it be possible to get the taskbar icon from Whatsapp (directly), copy that over to WhatsappTray?

Dicebar commented 4 years ago

I've been having this problem since a week a week or so. A minute or two after closing Whatsapp to the tray, I'll get a nice ol' 1 on the tray icon. Since it was so consistent (hurray for reproduction!) I opened and closed the tray a few times and copied the log for that period.

whatsapptray_log.txt

The offending lines are identical each time, with the last two characters 113c1092bf479aa6.--10 appearing to increment:

WhatsAppApi::IndexedDbChanged() - Found recv: 'o"lineI–6"log"5-o_# 2019-11-16 11:06:07.535:    recv: s1 [Conn, ...]"  timestampNÍŒaÕ:çvB{'
WhatsAppApi::IndexedDbChanged() - Found recv: 'o"lineIš6"log"<-o_# 2019-11-16 11:06:07.536:    recv: 113c1092bf479aa6.--10"   timestampNš‘aÕ:çvB{'
WhatsAppApi::IndexedDbChanged() - Found match for receivedMessage.

WhatsAppApi::IndexedDbChanged() - Found recv: 'o"lineIö7"log"5-o_# 2019-11-16 11:09:07.073:    recv: s1 [Conn, ...]"  timestampN'
WhatsAppApi::IndexedDbChanged() - Found recv: 'o"lineIú7"log"<-o_# 2019-11-16 11:09:07.074:    recv: 113c1092bf479aa6.--11"   timestampNš©Ö'
WhatsAppApi::IndexedDbChanged() - Found match for receivedMessage.

WhatsAppApi::IndexedDbChanged() - Found recv: 'o"lineIÎ9"log"5-o_# 2019-11-16 11:10:33.002:    recv: s1 [Conn, ...]"  timestampNf–Õ;çvB{'
WhatsAppApi::IndexedDbChanged() - Found recv: 'o"lineIÒ9"log"<-o_# 2019-11-16 11:10:33.002:    recv: 113c1092bf479aa6.--12"   timestampNf–Õ;çvB{'
WhatsAppApi::IndexedDbChanged() - Found match for receivedMessage.

If I can provide more information, do let me know. I hope this helps!

D4koon commented 2 years ago

Please try this beta-version https://github.com/D4koon/WhatsappTray/suites/4853728201/artifacts/137914918

Currently only tested on Windows 10. There might be problems with other Windows-versions.

It should look something like this: image

Please give feedback with used Windows-version (I'm especially interested in other Windows versions than 10) Thank you

Dicebar commented 2 years ago

I installed the linked version, and while Whatsapp minimized to tray as expected, the tray icon did not show any indication for new messages at all.

D4koon commented 2 years ago

I installed the linked version, and while Whatsapp minimized to tray as expected, the tray icon did not show any indication for new messages at all.

Thank you for your feedback. I noticed i still had a fixed path in this build and fixed it now.

Please try this version: https://github.com/D4koon/WhatsappTray/suites/4864576678/artifacts/138575078

Dicebar commented 2 years ago

That did it for me, thanks!