search

D4nielJ / recipe-app-rails

The Recipe app keeps track of all your recipes, ingredients, and inventory. It allows you to save ingredients, keep track of what you have, create recipes, and generate a shopping list based on what you have and what you are missing from a recipe.
0 stars 0 forks source link

Recipe App Group and Setup #13

Open D4nielJ opened 3 years ago

D4nielJ commented 3 years ago

In this activity, our team prepared a Kanban board with a GitHub project. This time there is not template to copy. We create a Kanban board from scratch. Project requirements are separate tasks and they have a card for each task.

Links

Team group

Emmyn5600 commented 3 years ago

Hi, @leonardodiasb and @D4nielJ

Good job so far! 👏🏼

Great work on making the project requirements:clap: You've done well implementing the project requirements, but there are still some issues which aren't been addressed yet

STATUS: CHANGES REQUESTED :recycle:

Changes requested.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding! :clap: :clap: :clap:

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

DeliceLydia commented 3 years ago

Status: Approved🎉🎉

Hi Team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard).. If you think that the code review was not fair, you can request a second opinion using this form.