DA0-DA0 / dao-contracts

CosmWasm smart contracts for Interchain DAOs.
https://docs.daodao.zone
BSD 3-Clause "New" or "Revised" License
206 stars 137 forks source link

Update lib versions #718

Closed taitruong closed 1 year ago

faddat commented 1 year ago

I'll cross check this by repeating it but from a glance I strongly approve of this change

taitruong commented 1 year ago

@JakeHartnell I saw there was a compile error (unknown feature 'proc_macro_span_shrink') when using latest nightly toolchain 1.72.0-nightly. Like when running this: cargo +nightly unit-test --locked

Found solution here: https://substrate.stackexchange.com/a/9069

So this one works: cargo +nightly-2023-06-15 unit-test --locked

I'm not familiar with CI and GitHub workflows. Only saw these configs install latest nightly toolchain here: justfile, basic.yml, codecov.yml and integration_tests.yml

JakeHartnell commented 1 year ago

Getting things fixed in #719! Then you can add this PR on top. : )

JakeHartnell commented 1 year ago

Going to need to rebase from development.

taitruong commented 1 year ago

Going to need to rebase from development.

Will do.

taitruong commented 1 year ago

@JakeHartnell, rebased from development. All tests went through.

lint exited with code 1 due to test -z "$(git status --porcelain)" - but dunno why: https://github.com/DA0-DA0/dao-contracts/actions/runs/5501499710/jobs/10025132611?pr=718

Regarding upgrading to latest lib versions: I prefer using versions "x.y" instead of "x.y.z". This way it allows including bug fixes and won't be too restrictive for integrating dao-contracts in other libs. Like:

JakeHartnell commented 1 year ago

Just needs just gen to update the schema and fix the CI.

taitruong commented 1 year ago

Just needs just gen to update the schema and fix the CI.

Done. All green now. Thx