DA0-DA0 / dao-contracts

CosmWasm smart contracts for Interchain DAOs.
https://docs.daodao.zone
BSD 3-Clause "New" or "Revised" License
202 stars 133 forks source link

Final CW4 cleanup #723

Closed NoahSaso closed 11 months ago

NoahSaso commented 11 months ago

The other cw4 cleanup PR (#691) was merged a bit too early. It was missing a contract validation and left the unused state variables in. This PR makes these changes.

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (29bea8d) 93.97% compared to head (b33b6ee) 93.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #723 +/- ## ============================================ Coverage 93.97% 93.98% ============================================ Files 62 62 Lines 5596 5600 +4 ============================================ + Hits 5259 5263 +4 Misses 337 337 ``` | [Files Changed](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/723?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0) | Coverage Δ | | |---|---|---| | [contracts/voting/dao-voting-cw4/src/contract.rs](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/723?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0#diff-Y29udHJhY3RzL3ZvdGluZy9kYW8tdm90aW5nLWN3NC9zcmMvY29udHJhY3QucnM=) | `94.44% <100.00%> (+0.25%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JakeHartnell commented 11 months ago

Closes #711.