Audit Fixes and Improvements

[JakeHartnell]

Address most of the issues from the recent smart contract audit, also fixes one or two things they didn't catch. Many improvements across the board.

Additionally:

• Closes #729

Major changes from the current development version:

• dao-voting-native-staked and dao-voting-token-factory-staked have been merged into one contract to reduce code duplication. When using an existing token, a new cw_tokenfactory_issuer is no longer instantiated as it was pointless and it would be impossible to garuntee if the admin would be set correctly.
• The API of cw_tokenfactory_issuer has been greatly simplified.
• cw_tokenfactory_issuer uses cw_ownable to implement two-step ownership transfer, as well as to allow for DAOs to easily reject ownership altogether.
• dao-voting-cw721-staked is now consistent with the other voting modules in terms of not taking an owner, the owner of a voting module should always be the DAO.
• Advanced features such as freezing, denylist, and more are disabled by default in cw_tokenfactory_issuer. DAOs must explicitly vote to enable them later so everyone can see what they are getting into.
• Hooks are now properly dispatched during staking and unstaking. Additionally, hooks have been merged into a new dao-hooks package to allow for better code reuse. A new DaoHooks enum contains all hooks used in the codebase to make it easy to write generic contracts leveraging any DAO hook.
• Better validation with more code reuse.
• Unsetting the BeforeSendHook, renouncing ownership, and disabling Token Factory admin have been documented and tested.

In addition, many other improvements have been added, including numerous small informational issues (non-critical) mentioned in the audit.

[codecov[bot]]

Codecov Report

Patch coverage: 78.89% and project coverage change: +0.39% :tada:

Comparison is base (bf3ef9c) 96.42% compared to head (508d81c) 96.81%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## development #742 +/- ## =============================================== + Coverage 96.42% 96.81% +0.39% =============================================== Files 189 191 +2 Lines 49902 49958 +56 =============================================== + Hits 48119 48369 +250 + Misses 1783 1589 -194 ``` | [Files Changed](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0) | Coverage Δ | | |---|---|---| | [...racts/external/cw-tokenfactory-issuer/src/error.rs](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0#diff-Y29udHJhY3RzL2V4dGVybmFsL2N3LXRva2VuZmFjdG9yeS1pc3N1ZXIvc3JjL2Vycm9yLnJz) | `0.00% <ø> (ø)` | | | [...cts/external/cw-tokenfactory-issuer/src/execute.rs](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0#diff-Y29udHJhY3RzL2V4dGVybmFsL2N3LXRva2VuZmFjdG9yeS1pc3N1ZXIvc3JjL2V4ZWN1dGUucnM=) | `0.00% <0.00%> (ø)` | | | [...cts/external/cw-tokenfactory-issuer/src/helpers.rs](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0#diff-Y29udHJhY3RzL2V4dGVybmFsL2N3LXRva2VuZmFjdG9yeS1pc3N1ZXIvc3JjL2hlbHBlcnMucnM=) | `0.00% <0.00%> (ø)` | | | [...racts/external/cw-tokenfactory-issuer/src/hooks.rs](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0#diff-Y29udHJhY3RzL2V4dGVybmFsL2N3LXRva2VuZmFjdG9yeS1pc3N1ZXIvc3JjL2hvb2tzLnJz) | `0.00% <0.00%> (ø)` | | | [...ntracts/external/cw-tokenfactory-issuer/src/msg.rs](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0#diff-Y29udHJhY3RzL2V4dGVybmFsL2N3LXRva2VuZmFjdG9yeS1pc3N1ZXIvc3JjL21zZy5ycw==) | `5.88% <0.00%> (+0.88%)` | :arrow_up: | | [...cts/external/cw-tokenfactory-issuer/src/queries.rs](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0#diff-Y29udHJhY3RzL2V4dGVybmFsL2N3LXRva2VuZmFjdG9yeS1pc3N1ZXIvc3JjL3F1ZXJpZXMucnM=) | `0.00% <0.00%> (ø)` | | | [...cts/proposal/dao-proposal-multiple/src/contract.rs](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0#diff-Y29udHJhY3RzL3Byb3Bvc2FsL2Rhby1wcm9wb3NhbC1tdWx0aXBsZS9zcmMvY29udHJhY3QucnM=) | `92.65% <ø> (ø)` | | | [...racts/proposal/dao-proposal-single/src/contract.rs](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0#diff-Y29udHJhY3RzL3Byb3Bvc2FsL2Rhby1wcm9wb3NhbC1zaW5nbGUvc3JjL2NvbnRyYWN0LnJz) | `99.18% <ø> (ø)` | | | [...taking/cw20-stake-external-rewards/src/contract.rs](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0#diff-Y29udHJhY3RzL3N0YWtpbmcvY3cyMC1zdGFrZS1leHRlcm5hbC1yZXdhcmRzL3NyYy9jb250cmFjdC5ycw==) | `99.83% <ø> (ø)` | | | [...cts/staking/cw20-stake-external-rewards/src/msg.rs](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0#diff-Y29udHJhY3RzL3N0YWtpbmcvY3cyMC1zdGFrZS1leHRlcm5hbC1yZXdhcmRzL3NyYy9tc2cucnM=) | `77.77% <ø> (ø)` | | | ... and [35 more](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/DA0-DA0/dao-contracts/pull/742/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DA0-DA0)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[codecov[bot]]

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella: