DA0-DA0 / dao-contracts

CosmWasm smart contracts for Interchain DAOs.
https://docs.daodao.zone
BSD 3-Clause "New" or "Revised" License
202 stars 132 forks source link

Added missing completed proposal queries to approval-single #767

Closed NoahSaso closed 7 months ago

NoahSaso commented 7 months ago

The dao-pre-propose-approval-single contract does not store pending proposals once they have been approved or rejected. This makes it impossible to retrieve past decisions and connect approval proposals used in dao-pre-propose-approver to existing proposals.

This PR adds queries to check whether or not a given approval ID is pending, and allows querying completed proposals. If approved, it also includes the created proposal ID. It also adds a query to get the completed pre-propose ID from the created proposal ID.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (development@db42d45). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #767 +/- ## ============================================== Coverage ? 96.27% ============================================== Files ? 203 Lines ? 50289 Branches ? 0 ============================================== Hits ? 48414 Misses ? 1875 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.