Closed NoahSaso closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e54d447
) 96.27% compared to head (4e7c398
) 96.32%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The ordering of approval-single List and ReverseList queries is incorrect and does not match the normal proposal modules. The forward list query has a
start_after
parameter but was sorted in descending order, which does not make sense. The opposite was true for the reverse list query.This PR makes the forward list query sort ascending, which makes sense for
start_after
, and the reverse list query sort descending, which makes sense forstart_before
.It also now matches the rest of the codebase.