DA0-DA0 / dao-contracts

CosmWasm smart contracts for Interchain DAOs.
https://docs.daodao.zone
BSD 3-Clause "New" or "Revised" License
206 stars 137 forks source link

Switch order of approval-single list queries #772

Closed NoahSaso closed 10 months ago

NoahSaso commented 10 months ago

The ordering of approval-single List and ReverseList queries is incorrect and does not match the normal proposal modules. The forward list query has a start_after parameter but was sorted in descending order, which does not make sense. The opposite was true for the reverse list query.

This PR makes the forward list query sort ascending, which makes sense for start_after, and the reverse list query sort descending, which makes sense for start_before.

It also now matches the rest of the codebase.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e54d447) 96.27% compared to head (4e7c398) 96.32%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #772 +/- ## =============================================== + Coverage 96.27% 96.32% +0.04% =============================================== Files 203 203 Lines 50300 50186 -114 =============================================== - Hits 48428 48341 -87 + Misses 1872 1845 -27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.