Closed NoahSaso closed 6 months ago
Attention: 36 lines
in your changes are missing coverage. Please review.
Comparison is base (
1187dba
) 96.32% compared to head (2a219e9
) 96.25%.
Files | Patch % | Lines |
---|---|---|
...e-propose/dao-pre-propose-approver/src/contract.rs | 0.00% | 35 Missing :warning: |
...ts/pre-propose/dao-pre-propose-approver/src/msg.rs | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
a3a72db
) 96.45% compared to head (5ab004f
) 96.50%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Currently, setting up the
dao-pre-propose-approver
contract is a one-way operation. Once thedao-pre-propose-approval-single
'sapprover
is set to the approver contract, there is no way to reset it back to the DAO. This is because the approval-single contract requires the current approver to be the one calling theupdate_approver
execute message.This PR adds a message to the approver contract to undo its setup, setting the approver back to the DAO and unregistering the proposal completed hook.