search

DA0-DA0 / dao-contracts

CosmWasm smart contracts for Interchain DAOs.
https://docs.daodao.zone
BSD 3-Clause "New" or "Revised" License
202 stars 132 forks source link

Fix vetoer bypassing only_members_execute flag #780

Closed NoahSaso closed 6 months ago

NoahSaso commented 6 months ago

This fixes a minor bug found during the Oak Security veto audit in which the vetoer could bypass the only_members_execute configuration, executing a proposal even if they are not a member of the DAO, after the veto timelock expires.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2cc2a6e) 96.43% compared to head (758e463) 96.45%.

Files Patch % Lines
...cts/proposal/dao-proposal-multiple/src/contract.rs 91.66% 1 Missing :warning:
...racts/proposal/dao-proposal-single/src/contract.rs 91.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## noah/2.4.0 #780 +/- ## ============================================== + Coverage 96.43% 96.45% +0.01% ============================================== Files 204 204 Lines 52194 52395 +201 ============================================== + Hits 50334 50537 +203 + Misses 1860 1858 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.