Support `active_threshold` in `dao-voting-cw4`

DA0-DA0 / dao-contracts

CosmWasm smart contracts for Interchain DAOs.

https://docs.daodao.zone

BSD 3-Clause "New" or "Revised" License

202 stars 132 forks source link

Support `active_threshold` in `dao-voting-cw4` #781

Open JakeHartnell opened 6 months ago

JakeHartnell commented 6 months ago

As a DAO, we would like to have SubDAOs where there needs to be a minimum number of members for the SubDAO to be active.

We support active_threshold for NFTs and token-based DAOs, might as well make it supported in membership / multisig based DAOs.

theghostmac commented 3 months ago

Hi @JakeHartnell,

I have just added this in my fork, and will make a PR in a moment. However, I want to verify that there will be need to:

Query SubDAOs based on active/inactive status.
Enforce rules for active/inactive SubDAOs and implement checks based on the status, maybe during proposal creation or voting etc to ensure only active SubDAOs can participate.
Adding and removing SubDAO members
Automatically toggle a SubDAO status based on amount of members >= active threshold.

Just a checklist we may have to include to this new feature...

JakeHartnell commented 3 months ago

To be clear, the contract that needs to be modified is contracts/voting/dao-voting-cw4. There are examples of implementing active threshold in contracts/voting/dao-voting-cw721-staked and contracts/voting/dao-voting-token-staked, use those for reference. Both of those examples, show the queries that need to be implemented, namely a QueryMsg::IsActive query.

Many of the features you listed are not actually needed for this as these features are handled via the voting module contract (i.e. dao-voting-cw4).