DA0-DA0 / dao-contracts

CosmWasm smart contracts for Interchain DAOs.
https://docs.daodao.zone
BSD 3-Clause "New" or "Revised" License
202 stars 132 forks source link

Support both osmosis and CW tokenfactory msg standards #788

Closed NoahSaso closed 6 months ago

NoahSaso commented 6 months ago

This adds support for the /cosmwasm.tokenfactory msg type URLs to cw-tokenfactory-issuer, now supporting both /cosmwasm. and /osmosis.. The feature flag osmosis_tokenfactory or cosmwasm_tokenfactory control which version of the contract gets built.

It also removes dependency on the token_bindings package which uses CosmosMsg::Custom(TokenFactoryMsg) because we now use stargate (CosmosMsg::Stargate) messages instead, which are supported on all chains since msgs are protobuf encoded. This is critical to supporting both token the cosmwasm. and osmosis. tokenfactory standards.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 239 lines in your changes are missing coverage. Please review.

Comparison is base (a3f15d7) 96.50% compared to head (3b5a112) 96.13%.

Files Patch % Lines
packages/cw-tokenfactory-types/src/cosmwasm.rs 0.00% 91 Missing :warning:
packages/cw-tokenfactory-types/src/msg.rs 0.00% 84 Missing :warning:
packages/cw-tokenfactory-types/src/shim.rs 0.00% 31 Missing :warning:
...cts/external/cw-tokenfactory-issuer/src/execute.rs 0.00% 29 Missing :warning:
...ts/external/cw-tokenfactory-issuer/src/contract.rs 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #788 +/- ## =============================================== - Coverage 96.50% 96.13% -0.37% =============================================== Files 204 207 +3 Lines 52518 52716 +198 =============================================== Hits 50680 50680 - Misses 1838 2036 +198 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.