DA0-DA0 / dao-contracts

CosmWasm smart contracts for Interchain DAOs.
https://docs.daodao.zone
BSD 3-Clause "New" or "Revised" License
202 stars 132 forks source link

Cast vote on proposal creation #799

Closed NoahSaso closed 4 months ago

NoahSaso commented 5 months ago

Resolves #798

This allows the proposer to cast a vote when creating a proposal, which also takes care of instant-passing proposals when the member with majority voting power proposes something (#759). It will fail if the proposer is not a member (when anyone may propose is enabled).

It works by simply chaining the vote execution function after the proposal creation. This makes it future proof by respecting all other relevant features (such as min_voting_period and allow_revoting, which would have been ignored by #776).

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7cc41b5) 96.17% compared to head (5b4cb1b) 96.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #799 +/- ## =============================================== + Coverage 96.17% 96.21% +0.03% =============================================== Files 207 207 Lines 53401 53909 +508 =============================================== + Hits 51359 51866 +507 - Misses 2042 2043 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JakeHartnell commented 4 months ago

CI for integrations testing is failing, but there is a fix for that here: https://github.com/DA0-DA0/dao-contracts/pull/715

NoahSaso commented 4 months ago

CI for integrations testing is failing, but there is a fix for that here: #715

sir that is a bounties contract 😂

can you split up the CI fix into a separate pr pls <3

JakeHartnell commented 4 months ago

Le fix for CI: https://github.com/DA0-DA0/dao-contracts/pull/801

NoahSaso commented 4 months ago

Le fix for CI: #801

thank you!

NoahSaso commented 4 months ago

hey @JakeHartnell seems the CI is failing for a cache issue? how do we resolve it D:

JakeHartnell commented 4 months ago

hey @JakeHartnell seems the CI is failing for a cache issue? how do we resolve it D:

Yolo merge? Ran test tube locally and everything passed so 99% sure it will work...