search

DA0-DA0 / dao-contracts

CosmWasm smart contracts for Interchain DAOs.
https://docs.daodao.zone
BSD 3-Clause "New" or "Revised" License
202 stars 132 forks source link

[feature] Updated SubDao functionality to have members count and an active threshold #808

Closed theghostmac closed 3 months ago

theghostmac commented 3 months ago

This pull request addresses the issue #781 "Support active_threshold in dao-voting-cw4" by updating the SubDao functionality to include a member count and an active threshold.

This ensures that SubDAOs can only be considered active if they meet the minimum required member count specified by the active threshold.

theghostmac commented 3 months ago

Can I redirect this PR to a separate branch? Seeing that development is the default..

JakeHartnell commented 3 months ago

This pull request addresses the issue https://github.com/DA0-DA0/dao-contracts/issues/781 "Support active_threshold in dao-voting-cw4" by updating the SubDao functionality to include a member count and an active threshold.

This PR is not exactly what I had in mind when I wrote the ticket which is my bad as I should have included more detail. The contract that needs to be modified is contracts/voting/dao-voting-cw4. There are examples of implementing active threshold in contracts/voting/dao-voting-cw721-staked and contracts/voting/dao-voting-token-staked, use those for reference.

Additionally, we try not to touch the core module unless we absolutely have to due to audit costs.

This PR just adds some metadata around this, but the core-active threshold logic is in the voting module contracts. Going to close for now, but happy to find time to chat about this issue if you want to take it on!