Add active threshold functionality to CW4 voting module, closes #781

DA0-DA0 / dao-contracts

CosmWasm smart contracts for Interchain DAOs.

https://docs.daodao.zone

BSD 3-Clause "New" or "Revised" License

202 stars 132 forks source link

Add active threshold functionality to CW4 voting module, closes #781 #819

Open theghostmac opened 2 months ago

theghostmac commented 2 months ago

Changelog

Added new custom error message to error.rs, InvalidThreshold
Added the query_is_active function and corresponding Query::IsActive
Added the execute_update_active_threshold function and corresponding ExecuteMsg::UpdateActiveThreshold
Added the new optional Config and updated the instantiate function to make use of it.

Author

GhostMac

JakeHartnell commented 2 months ago

Needs a few things:

Fix the build
Add tests for active_threshold and being able to update it
Make sure CI passes
Clean up

theghostmac commented 2 months ago

Needs a few things:

Fix the build

Add tests for active_threshold and being able to update it

Make sure CI passes

Clean up

I have updated the contract with everything you pointed out. Build passes. Moving on to the tests.

JakeHartnell commented 2 months ago

Needs a few things:

Fix the build

Add tests for active_threshold and being able to update it

Make sure CI passes

Clean up

I have updated the contract with everything you pointed out. Build passes. Moving on to the tests.

Close, but see above comments.

Get rid of CONFIG, it's duplicate state for no reason
Make sure to save ACTIVE_THRESHOLD on instantiation and validate that it's NOT ACTIVE_THRESHOLD::Percent
Get rid of ACTIVE_THRESHOLD::Percent in the IsActive query, it does nothing right now and we should not allow it
Fix linting errors and tests, CI should pass