Integrate cw-orch - Githubissues

DA0-DA0 / dao-contracts

CosmWasm smart contracts for Interchain DAOs.

https://docs.daodao.zone

BSD 3-Clause "New" or "Revised" License

202 stars 132 forks source link

Integrate cw-orch #831

Open Kayanski opened 1 month ago

Kayanski commented 1 month ago

This PR aims at adding cw-orch inside Dao-Dao. Tasks to fill :

[x] Add a cw-orch-interface package with all the contract interfaces.
[x] Add the derive macros on all execute and query msgs
[x] Write tests using cw-orch syntax
[ ] Osmosis Test Tube tests
[ ] Include artifacts in there (at least in crates.io release).

ismellike commented 1 month ago

Minor request It would be great to use the id = <default contract id> syntax for the contract interfaces. https://orchestrator.abstract.money/contracts/interfaces.html#creating-an-interface

Kayanski commented 3 weeks ago

Minor request It would be great to use the id = <default contract id> syntax for the contract interfaces. https://orchestrator.abstract.money/contracts/interfaces.html#creating-an-interface

yes god idea ! However, when doing so, you won't be able to use the 2 same contracts inside a project. You wouldn't be able to test or script simply with 2 daos for instance, is that acceptable ?

ismellike commented 2 weeks ago

Minor request It would be great to use the id = <default contract id> syntax for the contract interfaces. https://orchestrator.abstract.money/contracts/interfaces.html#creating-an-interface

yes god idea ! However, when doing so, you won't be able to use the 2 same contracts inside a project. You wouldn't be able to test or script simply with 2 daos for instance, is that acceptable ?

Ah ok! I wasn't aware of that, so it's probably not great from an external perspective. Thanks, happy with this as is.