DA0-DA0 / dao-dao-ui

InterChain DAO tooling UI.
https://daodao.zone
29 stars 22 forks source link

Remove @dao-dao/utils dependency from @dao-dao/types #1756

Closed NoahSaso closed 8 months ago

NoahSaso commented 8 months ago

There is a circular dependency where @dao-dao/types is dependent on @dao-dao/utils, which is bad. @dao-dao/types should not depend on any other packages (except @dao-dao/config), because every other package (except config) uses @dao-dao/types and @dao-dao/utils, and it causes issues when there are circular package dependencies.

This circular dependency was caused by some protobuf types needing to access util functions that encode/decode any protobuf message. To fix this, this PR moves generated protobuf types and some utils that the protobuf types depend on to the types package.