DA0-DA0 / dao-dao-ui

InterChain DAO tooling UI.
https://daodao.zone
29 stars 22 forks source link

Existing token existence not validated #1766

Closed NoahSaso closed 2 months ago

NoahSaso commented 7 months ago

A cw20 address was pasted into the existing token field when creating a new token factory DAO and it let it happen: https://testnet.daodao.zone/dao/migaloo1cqu7fd0j9fafu595rls7q0p8qkggwxyg73qe8z7974r56fve0jpq47gjev/home

Can we query the chain to see if a factory token exists before allowing the DAO to be created?

NoahSaso commented 2 months ago

this is now fixed by forcing it to attempt to load contract addresses as CW20s, since native tokens are never formatted like contract addresses.

it also now ensures that the token supply is nonzero, and shows an error otherwise.

fixed by daa365186d0d34aa9105ac4989a9e3f78a0b1f72