Not all Notificaiton class have Interface OSNotificationServiceInterface::sendMessages(array $messages)

DABSquared / DABSquaredPushNotificationsBundle

Push Notifications Bundle For Symfony 2, Designed like FOSCommentBundle

www.dabsquared.com

MIT License

29 stars 5 forks source link

Not all Notificaiton class have Interface OSNotificationServiceInterface::sendMessages(array $messages) #3

Closed snakewa closed 10 years ago

snakewa commented 11 years ago

AndroidNotification and BlackberryNotification does not have sendMessages implemented, so I guess sendMessages() should be optional or AndroidNotification and BlackberryNotification should implement it and throw an exception when they are invoked.

Because this will cause an error when Symfony2 try to compile them

bassrock commented 11 years ago

Agreed. And if someone wants to create a pull request with this functionality, I would be happy to merge it.

bassrock commented 11 years ago

Referencing this pull request #4

bassrock commented 10 years ago

@snakewa see #7 this will be included in there.