Marble mobile menu

[alexandercyu]

• Added border line between each menu item
• Remove 0.5 rem default margin below h6 coming from bootstrap for the mobile menu only
• Move 30px bottom margin for h6 to its own class and apply it to h6 headings in other parts of the site
• Add white version of close button (not implemented yet)

[mishaschwartz]

@alexandercyu please resolve the merge conflicts and then I'll have another look

[alexandercyu]

@alexandercyu please resolve the merge conflicts and then I'll have another look

The conflicts have been resolved.

[alexandercyu]

Looks good, when close button is implemented move the close button down on Y axis

Do you mean the 'X' button to close the mobile menu? That's already been implemented. What is the distance you want it moved down on the Y axis?

[alexandercyu]

I'm still waiting for a response to several comments from my previous review.

Either make changes, or leave a comment: explaining why you don't think the requested change is necessary, asking for a clarification, suggesting an alternative ...

Don't just ignore the review comments please.

Sorry, didn't mean to ignore those. It's just my habit of looking at the ones I get emails for. I should be looking at the entire list.

Anyway, those are done now.

[ShrutiK100]

Looks good, when close button is implemented move the close button down on Y axis

Do you mean the 'X' button to close the mobile menu? That's already been implemented. What is the distance you want it moved down on the Y axis?

Looks good, when close button is implemented move the close button down on Y axis

Do you mean the 'X' button to close the mobile menu? That's already been implemented. What is the distance you want it moved down on the Y axis?

Have created a new issue about this. Please check.

[alexandercyu]

Aligned hamburger and close buttons in mobile menu at their top left corners. Fixes #123

Changed opacity for close button in mobile menu.

[alexandercyu]

• On sm and md screen sizes the quick start menu is now all the way to the left (no padding or margins at all) which I'm pretty sure we don't want.

  • In Figma, the mobile menu items are horizontally aligned in the middle of the screen. Here, they are aligned to the left

  • In Figma, the close button is above the "MARBLE" title, not beside it

• Changes to the quickstart menu in the "website-cosmetic-changes" branch have fixed this behaviour.
• Aligned mobile menu items in the middle of the screen at the smallest screen size NOTE: this means the left margin may not be as it is defined in the design
• Mobile menu is now aligned to the left in tablet size. Left margin is kept at 49px as defined in the design
• The close button has changed since initial design. It is now a bit left and a bit above the Marble title.

[mishaschwartz]

@alexandercyu I'll review after conflicts have been resolved please

[alexandercyu]

@alexandercyu I'll review after conflicts have been resolved please

The Resolve Conflicts button is greyed out for me. Does that mean I have to do it locally instead of online?

[mishaschwartz]

Yes:

This branch has conflicts that must be resolved Use the command line to resolve conflicts before continuing.

[alexandercyu]

Yes:

This branch has conflicts that must be resolved Use the command line to resolve conflicts before continuing.

Ok, I've resolved the conflicts.

[mishaschwartz]

The close button has changed since initial design. It is now a bit left and a bit above the Marble title.

Yes, but the close button is still not fully above the title.

in Figma:

[alexandercyu]

The close button has changed since initial design. It is now a bit left and a bit above the Marble title.

Yes, but the close button is still not fully above the title.

in Figma:

I've added more space between the close button and title.