DACCS-Climate / marble-website

https://marbleclimate.com
0 stars 1 forks source link

Created mobile version of About page #125

Closed alexandercyu closed 5 months ago

alexandercyu commented 6 months ago

NOTE: h3 and h6 header tags still have a margin below them that have been taken out in previously made branches. Didn't want to duplicate the change here. Once those have been merged, it can be pulled into this branch.

NOTE: Button in FAQ section has a different size in the prototype than what is defined in the design. It is 99px wide instead of the standard 108px for a medium button or 75px for a small button. Is there a new design for this FAQ button?

alexandercyu commented 6 months ago

Sections that don't match figma design:

* mission

* our story

* DACCS

The "Executive" and "Scientific" text is too small on md size.

Fixed these sections but may have to check spacing under h3 and h6 titles again.

ShrutiK100 commented 6 months ago

NOTE: h3 and h6 header tags still have a margin below them that have been taken out in previously made branches. Didn't want to duplicate the change here. Once those have been merged, it can be pulled into this branch.

NOTE: Button in FAQ section has a different size in the prototype than what is defined in the design. It is 99px wide instead of the standard 108px for a medium button or 75px for a small button. Is there a new design for this FAQ button?

  • Added mobile versions of titles and content sections

Not sure which component you are referring to. If you are referring to the arrow it will be same as the browser one

alexandercyu commented 6 months ago

NOTE: h3 and h6 header tags still have a margin below them that have been taken out in previously made branches. Didn't want to duplicate the change here. Once those have been merged, it can be pulled into this branch. NOTE: Button in FAQ section has a different size in the prototype than what is defined in the design. It is 99px wide instead of the standard 108px for a medium button or 75px for a small button. Is there a new design for this FAQ button?

  • Added mobile versions of titles and content sections

Not sure which component you are referring to. If you are referring to the arrow it will be same as the browser one

It's this one: Screenshot 2024-05-15 at 9 58 12 AM (2)Crop

It has a different size than the other buttons that have already been created in the system. Screenshot 2024-05-15 at 9 57 46 AM (2)Crop Screenshot 2024-05-15 at 9 56 58 AM (2)Crop

ShrutiK100 commented 6 months ago

NOTE: h3 and h6 header tags still have a margin below them that have been taken out in previously made branches. Didn't want to duplicate the change here. Once those have been merged, it can be pulled into this branch. NOTE: Button in FAQ section has a different size in the prototype than what is defined in the design. It is 99px wide instead of the standard 108px for a medium button or 75px for a small button. Is there a new design for this FAQ button?

  • Added mobile versions of titles and content sections

Not sure which component you are referring to. If you are referring to the arrow it will be same as the browser one

It's this one: Screenshot 2024-05-15 at 9 58 12 AM (2)Crop

It has a different size than the other buttons that have already been created in the system. Screenshot 2024-05-15 at 9 57 46 AM (2)Crop Screenshot 2024-05-15 at 9 56 58 AM (2)Crop

All buttons on browser are Regular/Default and all buttons on mobile design are Medium/Default

alexandercyu commented 6 months ago

All buttons in mobile design are Medium/Default(defined in design system). Useful Links section needs to fall under feedback section, Feedback section has subsection-forum and feedback, Forum section is missing. All sections should have a 50px gap, 30px under all headings, 20px under all subheading and 20px between body and the buttons.

All FAQ section and Feedback section changes have been made in marble-mobile-home.

Wasn't the Forum section moved to the Community menu item?

All sections already have a 50px gap.

All h3 headings already have 30px under them.

All h6 headings seem to be a mix of 20px or 30px under them, depending on where they are used.

Do you mean 20px between the body and buttons on top of the button? Because 20px between the body and buttons (on the left of the button) was added this morning and you didn't tell me of that change.

alexandercyu commented 6 months ago

From #125 (review):

The "Executive" and "Scientific" text is too small on md size.

Changed the breakpoint of the "Executive" and "Scientific" text.

alexandercyu commented 6 months ago

Please put the underline under the committee options back

I'm not sure what you mean. Do you mean the Executive-Scientific buttons? It was never gone.

Screenshot 2024-05-17 at 9 44 16 AM (2)Crop Small Screenshot 2024-05-17 at 9 44 09 AM (2)Crop Large

alexandercyu commented 6 months ago

NOTE: h3 and h6 header tags still have a margin below them that have been taken out in previously made branches. Didn't want to duplicate the change here. Once those have been merged, it can be pulled into this branch. NOTE: Button in FAQ section has a different size in the prototype than what is defined in the design. It is 99px wide instead of the standard 108px for a medium button or 75px for a small button. Is there a new design for this FAQ button?

  • Added mobile versions of titles and content sections

Not sure which component you are referring to. If you are referring to the arrow it will be same as the browser one

It's this one: Screenshot 2024-05-15 at 9 58 12 AM (2)Crop It has a different size than the other buttons that have already been created in the system. Screenshot 2024-05-15 at 9 57 46 AM (2)Crop Screenshot 2024-05-15 at 9 56 58 AM (2)Crop

All buttons on browser are Regular/Default and all buttons on mobile design are Medium/Default

Made all buttons on desktop regular size and all buttons on mobile medium size.

alexandercyu commented 5 months ago

Add 30px under heading "Feedback" Screenshot 2024-05-17 at 3 49 01 PM

Add 30px un all 3 headings Screenshot 2024-05-17 at 3 47 33 PM

check the gap between useful links and connect with us Screenshot 2024-05-17 at 3 45 35 PM

Connect with us is not aligned as in design Screenshot 2024-05-17 at 3 45 11 PM

I've mentioned this before.

NOTE: h3 and h6 header tags still have a margin below them that have been taken out in previously made branches. Didn't want to duplicate the change here. Once those have been merged, it can be pulled into this branch.

All FAQ section and Feedback section changes have been made in marble-mobile-home.