DACCS-Climate / marble-website

https://marbleclimate.com
0 stars 1 forks source link

Fix background and alignment of node details section #148

Closed alexandercyu closed 5 months ago

alexandercyu commented 5 months ago

Fixes #140

alexandercyu commented 5 months ago

Background is now broken when screen width is md

image

Fixed background for md sizes. Also added a margin for node details at md size.

alexandercyu commented 5 months ago

The gap between heading and body is more than 30px, email and version also seems more than 30px. Needs to be a consitent 30px gap between all section elements Screenshot 2024-05-30 at 11 14 38 AM

I mentioned this in Figma. The space between email and version is 32px in desktop and I asked if it could be changed in mobile.

I've now changed it to 30px.

alexandercyu commented 5 months ago

Still don't see the 30px gap Screenshot 2024-05-30 at 11 42 18 AM Needs to be consistent 30px Screenshot 2024-05-30 at 11 14 38 AM

Screenshot 2024-05-30 at 11 57 05 AM (2) Screenshot 2024-05-30 at 12 14 53 PM (2) Screenshot 2024-05-30 at 12 15 18 PM (2) Screenshot 2024-05-30 at 11 58 04 AM (2)

alexandercyu commented 5 months ago

The margins look different because some of the child elements also have margins that get added to the 30px margin from the .node-main-info elements

Removed the default margins on the h2 and p elements.

alexandercyu commented 5 months ago

Alignment looks good Version is Caption • Regular • 14|Auto . Seems like its body1

Changed to caption font type.

alexandercyu commented 5 months ago

Version font change might have affected alignment on browser site. On browser email and version should align horizontally with the components on left hand side. Screenshot 2024-06-03 at 11 48 06 AM

Screenshot 2024-06-03 at 11 53 02 AM (3)

This seems to be aligned like the design. Am I missing something?

alexandercyu commented 5 months ago

Aligned the email with the description text.