search

DACSS / POLISCI753_tutorials

1 stars 12 forks source link

Fully qualify library paths in all tutorials #24

Closed stevelinberg closed 1 year ago

stevelinberg commented 1 year ago

As per the Google style guide, fully qualify all library calls.

equiv.clust -> sna::equiv.clust

stevelinberg commented 1 year ago

Admittedly, this does make some of the calls a bit cumbersome, as in:

print(karate.ig) -> igraph::print.igraph(karate.ig)

print() needs to become fully qualified to print.igraph() when specified as part of the igraph namespace, as the function for printing in igraph is actually print.igraph(), and print is an S3 generic.

However, it does make it very clear what's happening, whereas just print is vague magic for beginners. I think it's worth the tradeoff.

stevelinberg commented 1 year ago

Broke this out into separate issues for each chapter and support files, issues #26 - #39