DAGWorks-Inc / hamilton

Hamilton helps data scientists and engineers define testable, modular, self-documenting dataflows, that encode lineage/tracing and metadata. Runs and scales everywhere python does.
https://hamilton.dagworks.io/en/latest/
BSD 3-Clause Clear License
1.88k stars 126 forks source link

Add allow_module_overrides to AsyncDriver #1217

Closed rwhitten577 closed 2 weeks ago

rwhitten577 commented 2 weeks ago

AsyncDriver got left out of the .allow_module_overrides feature. Adding support for it . Fixes #1216

Changes

How I tested this

Notes

Checklist

sweep-ai[bot] commented 2 weeks ago

Hey @rwhitten577, here is an example of how you can ask me to improve this pull request:

@sweep Add a unit test for AsyncDriver that verifies the behavior when multiple modules with the same function name are provided directly to the constructor (rather than through the Builder), testing both with and without allow_module_overrides=True.

:book: For more information on how to use Sweep, please read our documentation.

rwhitten577 commented 2 weeks ago

Looks good! Would be nice to have a test for build_without_init (could just add this to the one you have, or create another), but that's not necessary

Thanks @elijahbenizzy , just added!