DAGWorks-Inc / hamilton

Hamilton helps data scientists and engineers define testable, modular, self-documenting dataflows, that encode lineage/tracing and metadata. Runs and scales everywhere python does.
https://hamilton.dagworks.io/en/latest/
BSD 3-Clause Clear License
1.88k stars 126 forks source link

Add e2e tests for async pipe_family #1231

Closed jernejfrank closed 1 week ago

jernejfrank commented 1 week ago

Addtion to #1223 -- Converted the initial test script to integration tests.

jernejfrank commented 1 week ago

Looks good! We're fixing the tests shortly -- they're failing due to stuff entirely unrelated to your change, we think. Then mind rebasing against main and pushing to the branch (we can double-check that they all pass)?

Sounds good -- FWIW locally the tests were passing.

skrawcz commented 1 week ago

Looks good! We're fixing the tests shortly -- they're failing due to stuff entirely unrelated to your change, we think. Then mind rebasing against main and pushing to the branch (we can double-check that they all pass)?

Sounds good -- FWIW locally the tests were passing.

you should be good to rebase now.