Open skrawcz opened 1 year ago
cc @CharityKithaka
Noted. Let me take it up @skrawcz
Hey, @skrawcz feeling better this week. Working on it.
Hey, @skrawcz feeling better this week. Working on it.
let me know when you want to sync.
@CharityKithaka let me know if you're still working on this.
Is your feature request related to a problem? Please describe. The docker container created for the examples does not enable one to run all the examples. The script to build environments that is used in the build process, excludes building environments for examples that have multiple requirements files, e.g.
requirements-ray.txt
is required to runrun_ray.py
in the data_quality example. This means that people can only run one variant in these examples.Describe the solution you'd like The build script should prepare all the environments in an example. E.g.
requirements.txt
would map tohamilton-env
requirements-ray.txt
would map tohamilton-env-ray
requirements-dask.txt
would map tohamilton-env-dask
Describe alternatives you've considered No doing this. Leaving things as is.
Additional context Script in question: https://github.com/DAGWorks-Inc/hamilton/blob/main/examples/make_python_virtualenv.sh
It is used here: https://github.com/DAGWorks-Inc/hamilton/blob/main/examples/Dockerfile