DAIRLab / dair_pll

DAIRLab Physics-based Learning Library
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Constrain friction coefficients to be positive #18

Closed ebianchi closed 1 year ago

ebianchi commented 1 year ago

Identical reasoning and implementation as constraining geometry lengths to be positive in #8 . During the learning process, the learned friction coefficients could go negative. If they did, the URDF exporting/importing failed. Here, we constrain friction coefficients to be non-negative, by distinguishing the learned parameters (which can take gradient steps during the learning process) from the reported physical quantities (which are used for exporting URDF files and later for simulation).