search

DAIRLab / dairlib

MIT License
66 stars 26 forks source link

virtual remote only #222

Closed Brian-Acosta closed 3 years ago

Brian-Acosta commented 3 years ago

This change is Reviewable

mposa commented 3 years ago

I'm OK merging this as-is, but as it does add a new dependency (pygame), we likely need some updates to our build instructions/process.

mposa commented 3 years ago

I was mostly going off the comments in the code here. However, a quick search over at Drake https://github.com/RobotLocomotion/drake/search?q=pygame&type= shows a pygame repository there. Can we piggy back off that here?

We could also add a unit test here, and the CI will check if the Docker image has pygame (my system also does, but who knows why).

Brian-Acosta commented 3 years ago

I'll go ahead and remove the pydairlib dependency for cleanliness' sake and merge. Thanks all. I looked at piggybacking off of drake's pygame dependency and couldn't get it working but maybe someone more familiar with Bazel could.