search

DAIRLab / dairlib

MIT License
65 stars 26 forks source link

Osc options fix #314

Closed Brian-Acosta closed 1 year ago

Brian-Acosta commented 1 year ago

This PR fixes a bug introduced in #308 - We switched the OSC from FastOsqpSolver to drake::solvers::OsqpSolverafter drake updates rendered FastOsqpSolver incompatible with MathematicalProgram, but we no longer set the osqp solver options.

This change is Reviewable

Brian-Acosta commented 1 year ago

Looks good! I think you need to be the approver still @yangwill

Jk. There's a memory leak - don't merge yet

Brian-Acosta commented 1 year ago

Closing since this has been resolved