search

DALTCORE / lara-pdf-merger

Laravel PDF merger, that works on Laravel 7.0 and PHP 7.4
MIT License
27 stars 36 forks source link

Use official tcpdf package to avoid conflicts #15

Open barryvdh opened 4 years ago

barryvdh commented 4 years ago

Is there a reason that tcpdf is included instead of required via https://github.com/tecnickcom/TCPDF ?

This could lead to autoload problems, because tcpdf is required in the global namespace. If this version is copied directly, I would suggest namespacing the tcpdf classes to avoid potential conflicts (eg. other libraries using tcpdf)

tamala73 commented 3 years ago

Is there a way to fix this? I do have a conflict -- trying to use this with elibyy\tcpdf