Improve user host-masking support for WHO & RWHO

[kobishmueli]

Improve user host-masking support for WHO:

• Let IRC Operators /who +h and /who -h match both the masked and real host while users will only be able to match the user's current host (masked for umode +H and real for umode -H targets).

Improve user host-masking support for RWHO.

• New match flag: M will always show the masked host in the reply.
• New output flag: H (capital H) will show the user's masked host in the reply.
• /rwho +h and /rwho -h will match both masked and real hosts.

-Kobi.

[eaescob]

👍

[kobishmueli]

Make /who and /rwho return consistent results for opers -- either both show the hostmask by default or both show the real host by default. Right now /who shows the hostmask and /rwho shows the real host and I think that gives an inconsistent experience.

/who is used by some of the clients to manage their internal address list so making it show real hosts for IRCops can cause information leakage to non-opers.

Making /rwho show the masked host/IP will break a lot of scripts but I'll happy to do it if one of you is willing to check the scripts and fix them (DALnet's scripts, not my own scripts). I'll also be happy to fix other inconsistencies of the two commands while I'm at it.

The "M" flag really should be an output flag, not a match flag. The M match flag conflicts with /who usage, "Flag M: check for user in channels I am a member of". Maybe we add "M" as one of the "special" /rwho output flags that will return the same default fields as /rwho except with the masked host.

I think we can just remove the M flag then and have IRCops use the normal /rwho output flags instead (i.e. h or/and H). In anyway, I agree choosing the M letter was a bad choice.

Kobi.

[eaescob]

Is this ready?

[rscs]

This PR can be closed. It was resubmitted under https://github.com/DALnet/bahamut/pull/122