search

DALnet / bahamut

The Bahamut IRC Daemon
http://www.dal.net/?page=Bahamut
Other
59 stars 42 forks source link

SQUIT with no parameters #176

Open rscs opened 4 years ago

rscs commented 4 years ago

There's logic in m_squit that closes the connection if SQUIT is called with no parameters:

/* This is actually protocol error. But, well, closing the link is very proper answer to that... */

This makes sense from a server<>server context, but if an oper accidentally types /squit with no parameters, it disconnects them. We should probably reply with ERR_NEEDMOREPARAMS if it's an oper doing the SQUIT.

jfcantu commented 4 years ago

But fixing this removes the opportunity to laugh at the IRCops dumb enough to do this.

In case, uh, someone were hypothetically dumb enough to do this.