Usermode H propagation bug

DALnet / bahamut

The Bahamut IRC Daemon

http://www.dal.net/?page=Bahamut

Other

59 stars 42 forks source link

Usermode H propagation bug #213

Closed rscs closed 2 years ago

rscs commented 2 years ago

Rework logic so usermode H is propagated through non-enabled hubs.
Don't penalize the user for flooding if they tried too soon.
Don't trigger a watch change if the mode is already set/unset.

eaescob commented 2 years ago

Curious, should we create a setting to automatically umode +H on connect and not oper hostmasked?

rscs commented 2 years ago

Curious, should we create a setting to automatically umode +H on connect and not oper hostmasked?

We have the following logic in do_user() which sets the user as +H if hostmasking is configured and enabled.

#ifdef USER_HOSTMASKING
        if((uhm_type > 0) && (uhm_umodeh == 1)) sptr->umode |= UMODE_H;
        else sptr->umode &= ~UMODE_H;
#endif

Are you saying maybe we should have a #define or config setting that specifically controls whether or not to +H by default? I could see a server or network not wanting +H to be the default.

rscs commented 2 years ago

Are you saying maybe we should have a #define or config setting that specifically controls whether or not to +H by default? I could see a server or network not wanting +H to be the default.

Nevermind ... @crigler reminded me that this already exists :).

uhm_umodeh has 3 settings documented in m_svsuhm

0 = hostmasking disabled
1 = hostmasking enabled with auto +H on connect
2 = hostmasking enabled with no auto +H