Let's try to send the sendq list on exit_client()

DALnet / bahamut

The Bahamut IRC Daemon

http://www.dal.net/?page=Bahamut

Other

59 stars 42 forks source link

Let's try to send the sendq list on exit_client() #85

Closed kobishmueli closed 4 years ago

kobishmueli commented 6 years ago

Right now, when users are killed/klined/akilled, they don't always get the kill message and are just getting disconnected with no message at all. This will (try to) send the sendq list with the error message right away.

Note that this should NOT be included in Bahamut 2.1.2.

Kobi.

kobishmueli commented 6 years ago

True, in my tests I actually tried to send the ERROR line directly to the FD with send() or safe_ssl_write()but I thought using send_queued() would be cleaner...

Kobi.

github-actions[bot] commented 4 years ago

Stale pull request message

eaescob commented 4 years ago

Are we still recommending this approach?