search

DAMO-NLP-SG / Video-LLaMA

[EMNLP 2023 Demo] Video-LLaMA: An Instruction-tuned Audio-Visual Language Model for Video Understanding
BSD 3-Clause "New" or "Revised" License
2.83k stars 263 forks source link

Possible bugs in LR scheduler #154

Open SAGNIKMJR opened 7 months ago

SAGNIKMJR commented 7 months ago

Hi, do you think the following could be bugs in the lr scheduler?

  1. https://github.com/DAMO-NLP-SG/Video-LLaMA/blob/ae12557b8510a7cc94baa3d3aea58ea07f6de76a/video_llama/common/optims.py#L83 should be step=total_cur_step,?
  2. https://github.com/DAMO-NLP-SG/Video-LLaMA/blob/ae12557b8510a7cc94baa3d3aea58ea07f6de76a/video_llama/common/optims.py#L91 should be epoch=total_cur_step - self.warmup_steps,?
  3. https://github.com/DAMO-NLP-SG/Video-LLaMA/blob/ae12557b8510a7cc94baa3d3aea58ea07f6de76a/video_llama/common/optims.py#L93 should be max_epoch=self.max_epoch * self.iters_per_epoch - self.warmup_steps,?