Closed colinxfleming closed 6 years ago
Progress:
ClinicFinder::Locator
now returns clinics. Or at least it should! Heads up @tingaloo -- see the other PR in the dcaf app you spun up around this. Should be at least something you can build around if you point it at this branch.I'm declaring victory on this, and doing affordability and cost in a separate PR since this is pretty huge already. Going to leave things open for a few days just in case the original team of @katherinebui @sierramclawhorn @saragilford or @cschlessinger would like to weigh in and add thoughts -- the
@tingaloo right now this is returning clinic-like objects but I expect we'll want to return distance or something too. Will wait for signal from you on what exactly we should bring back.
Initial stab at remixing this to take clinic objects, as well as break it out a little bit into more specific concerns. The other notable thing here is that the common filters (on accepting NAF, Medicaid, and the gestation range) are moved up to the point of initialization, just for redundancy's sake.
@katherinebui @sierramclawhorn @saragilford @cschlessinger this'll pretty much hew exactly to the code you all wrote last march, which is still great and very effective! Going to take this opportunity to break it out into specific modules while I'm wrenching around, hope that's cool with you all.
ps I had no idea that you could pass named arguments in by appending a colon to them, so that's awesome -- thanks for teaching me that! I'm going to use that probably all the time now.
@tingaloo for awareness that there's some forward momentum on this.