General QA review

[eheintzelman]

Thanks for creating an issue! Please fill out this form so we can be sure to have all the information we need, and to minimize back and forth.

• What are we trying to do? Make the design look like the mockups.

• What feature or behavior is this required for? Make it even easier to use.

• How could we solve this issue? (Not knowing is okay!) Review design overall for inconsistencies, funky stuff.

• Anything else?

[eheintzelman]

Sandbox

• Left align column titles with column data (all sections in sandbox) (#1246)

• Same issue with table alignment on the 'Change Log' and 'Call Log' sections. Left align column titles with column data (#1246)

• Consider moving plus sign left, adjacent to ellipses. I'm concerned that users would potentially think the plus sign is a call to action, like the delete and call icons, instead of the indicator for showing the full note. (all sections in sandbox) (#1247)

Dropdown boxes (#1249)

• Recommend a simple dropdown arrow instead of what looks like a spinner for dropdown boxes with non-numeric data. See US web design standards (https://standards.usa.gov/components/form-controls/#dropdown)
• For input boxes with numeric data, recommend a spinner - when you click the up arrow, steps up one unit, for example from 3 weeks to 4 weeks. Users can also type in directly, which would be faster than using a dropdown. Here is an example: https://jqueryui.com/spinner/ @mebates what do you think? (this has evolved some, but see #1249 )
• See input boxes on patient information, abortion information, and pledge fulfillment tabs

To be continued!

[eheintzelman]

Abortion Information tab (#1248)

• Decrease the vertical spacing between these two checkboxes. Make it consistent with the two 'enable' checkboxes on the left.

Call Log (I THINK when we rolled this out we decided to keep it a link rather than a button, going to wontfix this one. See https://github.com/DCAFEngineering/dcaf_case_management/pull/610 for where @mebates explicitly refs it as a link. -CF)

• Recommend changing 'Record new call' to a button style, since it is an action.

• A button styled like this in the 'Notes' section.

Error proofing form fields with text input (Fixed in the short term by requiring a number, though it doesn't put the form into an error state. Marking as 'fixed enough')

• Right now the text input fields are not error proof. You can enter 'very old' in the 'Age' field, and nothing tells the users to put in a 2 digit number instead. It would be really tight if we added added some kinds of data validation and feedback to the user. Not a must have but something to consider.
• The only exception is the phone number field for saving a patient. There already is feedback for this field.
• What do folks think about tackling this? If it is a yes, I'd be happy to look into possible solutions for providing the user feedback.

Behavior of Alerts (def doable)

• Great that we have a notification to the user that a patient has been saved successfully. Can we have it automatically disappear after a 5 seconds? It's extra work for the user to have to click out of it.

• Anytime a change is made to the summary section (Correction - this applies to the top summary section, patient info or abortion info), the 'patient info successfully saved' alert shows up again. Is this necessary? Is the information so important that there should be instant notification that changes were made, for every little change? @lwaldsc @NerdyGirl537 what do you think? If we'd like to give the user feedback when making changes to this section, recommend positioning the feedback close to the form field that was changed. If we decide we'd like to give this feedback, can look into ways to do this. (yep, hooking to the top)

To be continued!

[eheintzelman]

Preferred language dropdown (located in 'patient information' tab)- - UPDATE - ADDRESSED IN CONFIG MGMT

• In the sandbox, English is the only choice that is showing up. Not sure why. I assume this should include at least Spanish and possibly other languages?

Abortion Information tab (fixed with numbers validation, all set)

• Can we round the 'outstanding balance' to two decimal points? Would like to avoid this, which happened when I entered $150.90 for the abortion cost.
  Alternatively, we could round 'abortion cost' and all pledge amounts and contributions to the nearest dollar.

• DCAF Pledge ToolTip does not function (got this working in the broader tooltips, all set)

• What does the 'Referred to clinic' checkbox mean? No problem, if this is clear for case managers. - UPDATE - CLEAR TO CMs

Submitting Pledges & Cancelling pledges

• Vertically center the text with the number. Add more spacing between number and text. This is located on the modals for submitting or cancelling pledges. There are 3 modals with this issue re: submitting and 2 modals re: cancelling.

• Increase padding on all sides of container encompassing the text for all of these modals. Make it consistent with the styling margins on the call modal.

• Can we delete the 'previous' button on modal numero 1 for both sequences (submitting and cancelling)? It doesn't appear to have a purpose.

• Check the button styling for the buttons in all submitting & cancelling pledges modals. Some have a light blue highlighted border. Is there a reason for this? Other times, there is a border around buttons with a grey fill. For consistency with the original design, recommend no border when there is a color fill.

• Overall, the styling on these modals could use a review from a visual designer (@mebates?)

• After submitting a pledge, the pledge fulfillment fields show up under the patient info section. See screenshot below. Just a bit wonky. It goes away once you exit out of the patient and come back to it. UPDATE - just to clarify, this pledge fulfillment fields are showing up on the patient info tab, when you scroll down the page past the patient info fields.

To be continued!

[NerdyGirl537]

@eheintzelman for your questions: Language is now a pick list updated under the admin profile in the Admin Tools --> Config Management

For the abortion amount, I would recommend keeping it with 2 decimal places. I think that would work better. Just my opinion. @lwaldsc Thoughts?

The CMs know what to do with the 'Referred to Clinic' check box.

On pledge fulfillment, that only shows up if you are an admin user. The CM user doesn't see this.

[lwaldsc]

I would round to the nearest dollar. We almost never use cents.

[colinxfleming]

@eheintzelman my email just reminded me that hacktoberfest is coming, which means that a bunch of people will likely be looking to make one-off contributions such as UX fixes. In other words, keep these coming and feel empowered to get EXTREMELY nitpicky!

[colinxfleming]

@eheintzelman re the dropdown button, I think there's a path to that but it's not super clear how to break it up off the top of my head. a great flag though. Note to self to mull that one over!

(j/k I moved it to #1249)

[eheintzelman]

@colinxfleming My two cents (different from my initial assessment) is that we can leave the dropdown as is. See my comment in #1249

@lwaldsc Tried to clarify my comment about pledge fulfillment data getting wonky, above.