DARIAEngineering / dcaf_case_management

Rails-based case management system for abortion funds
MIT License
87 stars 245 forks source link

Budget Bar doesn't accurately reflect money sent #2757

Closed elimbaum closed 2 years ago

elimbaum commented 2 years ago

Thanks for creating an issue! Please fill out this form so we can be sure to have all the information we need, and to minimize back and forth.

Accurately display funds sent on budget bar. If amount sent by fund does not equal pledged, budget bar still lists the pledged amount as being sent. Maybe this is a reallllllllly funky edge case, but I think it's incorrect behavior that we could improve.

Budget bar

Better validation, and maybe change which value is displayed on budget bar.

pics ->

ex... we pledge $52. we send $60.

Screen Shot 2022-11-22 at 17 29 05

but budget bar says we sent $52! this is true in the reverse (sent < pledged). i don't know a ton about budget bar usage but this feels incorrect?

Screen Shot 2022-11-22 at 17 29 10
colinxfleming commented 2 years ago

I think I can clear this up - the tricky part here is the disambiguation between pledge money, sent money, and fulfilled money. I'm using ecommerce here as a rough metaphor.

Let me know if that makes sense!

elimbaum commented 2 years ago

cool, that makes sense. i never really paid attention to government contracting but i think we had some equivalent a la commit/obligate/expend etc.

As such, we don't represent fund payout on the budget bar, just pledge amounts.

so, this is not a bug, correct? if so i'll close.

colinxfleming commented 2 years ago

yep, gov contracting expenditures are probably a similar analog! Not a bug, expected behavior.