search

DARIAH-DE / shib-http-client

Minimalistic wrapper around the Apache HTTPClient adding Shibboleth support
Apache License 2.0
16 stars 8 forks source link

Only HTTP/1.1 200 OK is an acceptable response for Basic Auth on ECP #4

Closed spaetow closed 11 years ago

spaetow commented 11 years ago

Hi Richard, apparently if wrong user details are provided, it won't be the SAML response that contains authentication responses, but the web server itself may also respond with a HTTP/1.1 401 Not Authorized error message. Naturally, that can't be parsed since it is not a SOAP response. Thought this might be useful to check the return code before continuing.

reckart commented 11 years ago

Good point! I have a feeling that down the road other codes than 200 might crop up, but for now that seems to be a good assumption.