DARIAH-ERIC / lexicalresources

Data space of the DARIAH Lexical Resources Working Group
https://dariah-eric.github.io/lexicalresources/
BSD 2-Clause "Simplified" License
18 stars 24 forks source link

Values of the @function attribute of the <metamark> element in examples #214

Open daliboris opened 9 months ago

daliboris commented 9 months ago

I looked at the <metamark> element in the examples in the Guidelines and found very similar main names for the @function attribute. i.e. Marker, Separtator, Delimiter:

<metamark function="exampleMarker">○</metamark>
<metamark function="relatedEntryMarker">○</metamark>
<metamark function="subentryMarker">■</metamark>
<metamark function="entrySeparator">◆</metamark>
<metamark function="senseSeparator">◆</metamark>
<metamark function="senseDelimiter">§</metamark>
<metamark function="lemmaDelimiter">,</metamark>

Is the difference between Marker, Separator and Delimiter so significant that we should keep them all, or can we just use one or two preferred names?

anacastrosalgado commented 9 months ago

In my opinion, Delimiter is enough and I have arguments in favour.

ttasovac commented 9 months ago

I'm ok with unifying this in the examples and using "Delimiter". The values of the function attribute here are not hard-coded in the schema, but I do see the benefit of uniformity in the values we use in the examples.

Boris, shall we use this simple update to refresh your knowledge of the workflow we discussed a while back? You would need to:

I would then check the PR and merge it into the dev branch. As you may remember, I'm not merging individual commits into master. We do individual commits into dev, and then periodically merge the dev branch as a new release into the master.

daliboris commented 8 months ago

Hi @ttasovac, just noticed this assignment for me. I will try to do my best (in the next week?).

ttasovac commented 5 months ago

@daliboris just a small reminder...