search

DARMA-tasking-internal / darma-frontend

Header library providing the frontend programming model for the DARMA asynchronous many-task model
Other
7 stars 0 forks source link

almost nothing has virtual destructors #76

Open jjwilke opened 6 years ago

jjwilke commented 6 years ago

all abstract objects need virtual destructors

dhollman commented 6 years ago

@jjwilke Can you be more specific with this? I have virtual destructors on everything that I can find in the backend API. There are a few things where the virtual destructor is private or deleted because the object is never supposed to be deleted via a pointer to that object. Other things without virtual destructors are that way because they're not supposed to have vtables.

jjwilke commented 6 years ago

This was mostly in the frontend. I got a bazillion warnings about delete being called on non-virtual destructors when I tried to build. I'll push what I changed into a branch on both back/front.

From: David Hollman notifications@github.com<mailto:notifications@github.com> Reply-To: DARMA-tasking/darma-frontend reply@reply.github.com<mailto:reply@reply.github.com> Date: Monday, February 12, 2018 at 10:44 AM To: DARMA-tasking/darma-frontend darma-frontend@noreply.github.com<mailto:darma-frontend@noreply.github.com> Cc: "Wilke, Jeremiah J" jjwilke@sandia.gov<mailto:jjwilke@sandia.gov>, Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Subject: [EXTERNAL] Re: [DARMA-tasking/darma-frontend] almost nothing has virtual destructors (#76)

@jjwilkehttps://github.com/jjwilke Can you be more specific with this? I have virtual destructors on everything that I can find in the backend API. There are a few things where the virtual destructor is private or deleted because the object is never supposed to be deleted via a pointer to that object. Other things without virtual destructors are that way because they're not supposed to have vtables.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/DARMA-tasking/darma-frontend/issues/76#issuecomment-365021612, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAGh2RTFv3m4TP0qTMylIX13T8zNEvmuks5tUIaCgaJpZM4R4cpY.