search

DARMA-tasking / LB-analysis-framework

Analysis framework for exploring, testing, and comparing load balancing strategies
Other
3 stars 1 forks source link

#237: Implement memory-aware criterion using user-defined memory constraints and update LBAF-Viz to keep track of these #316

Closed ppebay closed 1 year ago

ppebay commented 1 year ago

Resolves #237

ppebay commented 1 year ago

As part of this PR the LBAF-Viz is improved, not showing above-constraint values (which happen for instance when the max memory upper-bound is not satisfied):

Screen Shot 2022-11-28 at 1 00 07 AM
ppebay commented 1 year ago

Visualizer was modified as part of this work: the per-rank QOI can now be changed at will:

With rank work:

Screen Shot 2022-11-29 at 5 15 33 PM Screen Shot 2022-11-29 at 5 15 18 PM

With rank load:

Screen Shot 2022-11-29 at 5 19 29 PM Screen Shot 2022-11-29 at 5 19 41 PM
ppebay commented 1 year ago

One PR #315 is merged, we will be able to view the memory-related QOIs @lifflander @nlslatt @nmm0 @PhilMiller

ppebay commented 1 year ago

Now tracking/visualizing arbitrary rank-level QOI, i.e., max_memory_usage:

Screen Shot 2022-11-29 at 11 58 41 PM Screen Shot 2022-11-29 at 11 58 53 PM
ppebay commented 1 year ago

Comment for reviewers: constrained optimization is not part of this PR, which therefore does not resolve #314 This will be dealt with in subsequent branch/PR.

ppebay commented 1 year ago

Bug that occurred when no default maximum for visualization QOI was specified, is now fixed:

Screen Shot 2022-11-30 at 11 35 03 PM Screen Shot 2022-11-30 at 11 35 11 PM Screen Shot 2022-11-30 at 11 35 20 PM

N.B.: in this case now, the space-time max of the QOI will be used.

ppebay commented 1 year ago

Also here is the behavior when an upper bound was specified (for the optimization process) for the same QOI as the one selected to be visualized:

Screen Shot 2022-11-30 at 11 38 08 PM Screen Shot 2022-11-30 at 11 37 52 PM
ppebay commented 1 year ago

@nlslatt I think all comments are addressed