search

DARMA-tasking / LB-analysis-framework

Analysis framework for exploring, testing, and comparing load balancing strategies
Other
3 stars 1 forks source link

#317: Reformat style of lbsStatistics, remove special handling of text string for imbalance file #319

Closed ppebay closed 1 year ago

ppebay commented 1 year ago

Fixes #317

ppebay commented 1 year ago

In passing @lifflander @nlslatt : is this imbalance.txt file (containing only the final value of the per-rank load imbalance) still needed? My recollection is that we wanted to use this for post-processing purposes, but the information is in the Exodus output anyway.

nlslatt commented 1 year ago

In passing @lifflander @nlslatt : is this imbalance.txt file (containing only the final value of the per-rank load imbalance) still needed? My recollection is that we wanted to use this for post-processing purposes, but the information is in the Exodus output anyway.

I had no memory of there being an imbalance.txt file, so I'm not sure.

ppebay commented 1 year ago

Thanks @nlslatt , I guess we don't remember it, it probably means we don't need it -- if @lifflander agrees I will also remove it as part of this PR.

ppebay commented 1 year ago

@cz4rs agreed -- in fact we had this somewhere in the "grand plan" for CI/CD but we never got to it I guess. Creating follow-on issue