search

DARMA-tasking / LB-analysis-framework

Analysis framework for exploring, testing, and comparing load balancing strategies
Other
3 stars 1 forks source link

#322: Refactoring to remove edge cache; create edge updater; and fix issue discovered in inter-object visualization #326

Closed ppebay closed 1 year ago

ppebay commented 1 year ago

Resolves #322 Fixes #328

NB: the latter was discovered while working on the former

ppebay commented 1 year ago

Fixing #328 as part of this PR as it is not unrelated to #322

BEFORE:

Screen Shot 2022-12-12 at 4 52 36 PM

AFTER:

Screen Shot 2022-12-12 at 4 51 27 PM

Notice the additional edges in the latter image

ppebay commented 1 year ago

Iteration 0

Object view:

Screen Shot 2022-12-12 at 5 00 09 PM

Rank view:

Screen Shot 2022-12-12 at 5 02 29 PM

@lifflander @nlslatt @PhilMiller aggregation appears to work as expected initially

ppebay commented 1 year ago

Iteration 1:

Object view:

Screen Shot 2022-12-12 at 5 04 23 PM

Rank view:

Screen Shot 2022-12-12 at 5 04 33 PM

But also at subsequent iterations after edges updates (as opposed to previous method of re-computing inter-rank edge graph)

ppebay commented 1 year ago

Iteration 2:

Object view:

Screen Shot 2022-12-12 at 5 06 56 PM

Rank view:

Screen Shot 2022-12-12 at 5 07 06 PM
ppebay commented 1 year ago

Iteration 8:

Object view:

Screen Shot 2022-12-12 at 5 08 52 PM

Rank view:

Screen Shot 2022-12-12 at 5 08 40 PM

Making this PR ready for review @lifflander @nlslatt @PhilMiller