DARMA-tasking / LB-analysis-framework

Analysis framework for exploring, testing, and comparing load balancing strategies
Other
3 stars 1 forks source link

Fix terminal background option in configuration file #347

Closed ppebay closed 1 year ago

ppebay commented 1 year ago

The terminal_background option is not portable. We need to find a better solution.

tlamonthezie commented 1 year ago

Currently the terminal background is used by the logger to set a specific fore color for the message The light option tells to write messages in black The dark option tells to write messages in light white The option was introcuced when resolving #154 because the messages where always written in light_white in the past but "White on white is not very easy to read"

The problem is it is defined in configuration file and can be different between different config files. BUT the user's terminal color scheme does not change and maybe only light (or only dark) are readable for this user.

To resolve the I see several possibilities:

ppebay commented 1 year ago

Thanks @tlamonthezie

Let us do the second option you suggested above -- and have the correct background set based on the environment that can be detected by LBAF.

tlamonthezie commented 1 year ago

Thanks @tlamonthezie

Let us do the second option you suggested above -- and have the correct background set based on the environment that can be detected by LBAF.

Ok we will remove the terminal_background option and let the host machine render the log messages.