#376: rework import structure in lbafapp and other files

[tlamonthezie]

Fixes #376

This pull request includes the following related to the rework of the import structure

• Setup lbaf in editable mode (added to the requirements files for pip)
• Make setup working and test :
  • Validation & Corrections for the package setup
  • Addition of a console script (to run the LBAF application directly by typing lbaf in a console)
• Some code quality changes (with the help of Pylint)
• Some development configuration files to help with code quality
• Refactoring
• upgrade acceptance tests and stepper tests to be run also with python 3.9 on the CI
• Update README.md

Also includes changes from #367 following a merge done because of too many conflicts between the 2 branches

[ppebay]

@tlamonthezie when trying to run python LBAF_app.py --config conf.yaml for this branch, I am getting the following error:

Traceback (most recent call last):
  File "LBAF_app.py", line 11, in <module>
    from lbaf import __version__, PROJECT_PATH
ModuleNotFoundError: No module named 'lbaf'

[tlamonthezie]

Hello @ppebay it seems that your python path is not valid or you did not install the updated requirements file

• To install the requirements in dev mode run pip install -r requirements-{python-version}.txt or just run the last NEW requirement pip install -e . from your project path. (It will install lbaf as a package)
• As an alternative you can fix the python path by running export PYTHONPATH=${PYTHONPATH}:{YOUR_PROJECT_PATH}/src to enable python to resolve lbaf.* imports but this solution is only required if lbaf package is not installed

[ppebay]

@tlamonthezie I am not sure what you mean by the fact that my Python path not being valid, as I have not changed anything, and am able to run LBAF develop without any issue. It is only with this PR that I am encountering the problem described above.

[tlamonthezie]

@tlamonthezie I am not sure what you mean by the fact that my Python path not being valid, as I have not changed anything, and am able to run LBAF develop without any issue. It is only with this PR that I am encountering the problem described above.

@ppebay requirements installation is enough to run LBAF. Could you please run the command to install the requirements again and let me know if it works on your side. In the CI and on my machine it works correctly. The way we run LBAF with develop is no more applicable with this PR because the full logic of imports has been changed. If you install the requirements you do not have to change your Python path (lbaf is automaticcally available as python package so no need to add to the Python path)

[ppebay]

@tlamonthezie now I understand! I thought my packages were up-to-date (for 3.8) but with the latest changes it's not the case any more. Now that makes more sense like this. Thank you.

I was able to run, and I am now verifying, test case by test case.

Stay tuned...

[ppebay]

Everything working as expected.

Thank you for the hard work @tlamonthezie