Closed pierrepebay closed 1 year ago
There is a Pylint: FAIL in the tox run in the CI, caused by 5 errors, as can be seen in these two pylint runs: https://github.com/DARMA-tasking/LB-analysis-framework/actions/runs/5100999367/jobs/9169599480#step:7 lines 1200, 1201, 1215, 1217, 1389 https://github.com/DARMA-tasking/LB-analysis-framework/actions/runs/5100999367/jobs/9169599480#step:7 lines 1203, 1204, 1218, 1220, 1384 Although these do not (for now) produce actual python errors when using the applications, the pylint errors that are thrown show that they could potentially lead to some issues later on, so fixing them would be appropriate.
Pylint: FAIL
pylint
tox.ini needs to have line 54 ignore_errors=true changed to ignore_errors=false so the pylint errors cause a CI failure. Some Pylint errors might need to be ignored in the .pylintrc with ignored-classes.
tox.ini
ignore_errors=true
ignore_errors=false
.pylintrc
ignored-classes
pierrepebay
commented
1 year ago
There is a
Pylint: FAILin the tox run in the CI, caused by 5 errors, as can be seen in these two pylint runs: https://github.com/DARMA-tasking/LB-analysis-framework/actions/runs/5100999367/jobs/9169599480#step:7 lines 1200, 1201, 1215, 1217, 1389 https://github.com/DARMA-tasking/LB-analysis-framework/actions/runs/5100999367/jobs/9169599480#step:7 lines 1203, 1204, 1218, 1220, 1384 Although these do not (for now) produce actual python errors when using the applications, thepylinterrors that are thrown show that they could potentially lead to some issues later on, so fixing them would be appropriate.