search

DARMA-tasking / LB-analysis-framework

Analysis framework for exploring, testing, and comparing load balancing strategies
Other
3 stars 1 forks source link

Verify/Update the online documentation #393

Closed cwschilly closed 12 months ago

cwschilly commented 1 year ago

Related to #376

cwschilly commented 1 year ago

Running JSON_data_files_validator_loader and vt_data_extractor.py from the command line leads to errors. Are these still intended to be used independently by users, or are they meant to be interacted with indirectly elsewhere in the code base? (For example, running test_JSON_data_files_validator.py calls the validator loader and works perfectly)

tlamonthezie commented 1 year ago

Running JSON_data_files_validator_loader and vt_data_extractor.py from the command line leads to errors. Are these still intended to be used independently by users, or are they meant to be interacted with indirectly elsewhere in the code base? (For example, running test_JSON_data_files_validator.py calls the validator loader and works perfectly)

JSON_data_files_validator_loader cannot be currently run alone (it is called internally by the LBAF application) but it could be made runnable easily with the addition of a main function and by using absolute imports to the lbaf package. We have to create an issue for that. Thank you @cwschilly for the newly created issue #396

cwschilly commented 1 year ago

I still need to update the wiki and README after resolution of #396 and #397

stmcgovern commented 1 year ago

After discussion, this issue concerns only the content of the documentation and the modifications to deploy docs workflow have been split off into issue #419 .

cwschilly commented 12 months ago

@ppebay This issue can be closed with #424